Bug 69094

Summary: Shrink HTMLAnchorElement on 32-bit.
Product: WebKit Reporter: Andreas Kling <kling>
Component: DOMAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
none
Proposed follow-up patch darin: review+, darin: commit-queue+

Andreas Kling
Reported 2011-09-29 10:37:57 PDT
SSIA.
Attachments
Proposed patch (1.21 KB, patch)
2011-09-29 10:40 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Proposed follow-up patch (1.41 KB, patch)
2011-09-29 13:57 PDT, Andreas Kling 		darin: review+
darin: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-09-29 10:40:21 PDT
Created attachment 109174 [details] Proposed patch
WebKit Review Bot
Comment 2 2011-09-29 13:29:23 PDT
Comment on attachment 109174 [details] Proposed patch Clearing flags on attachment: 109174 Committed r96352: <http://trac.webkit.org/changeset/96352>
WebKit Review Bot
Comment 3 2011-09-29 13:29:27 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 4 2011-09-29 13:37:44 PDT
Seems a little strange to use 31 bits for link relations since there are 18 of them total, not 31!
Andreas Kling
Comment 5 2011-09-29 13:43:18 PDT
(In reply to comment #4) > Seems a little strange to use 31 bits for link relations since there are 18 of them total, not 31! I thought I was being a little future proof, since we had 31 bits available anyway. I don't mind changing it to 18 bits wide if you prefer.
Darin Adler
Comment 6 2011-09-29 13:45:58 PDT
If I was doing this I would add a comment to the end of the enum mentioning the bitfield below and have the bitfield be exactly the right size.
Andreas Kling
Comment 7 2011-09-29 13:57:16 PDT
Created attachment 109199 [details] Proposed follow-up patch
Note You need to log in before you can comment on or make changes to this bug.