Summary: | Refactor IDL attributes about constructor | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, ap, dominicc, donggwan.kim, haraken, japhet, morrita, sam, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 65839 | ||||||||||
Attachments: |
|
Description
Kentaro Hara
2011-09-29 01:53:54 PDT
Created attachment 109137 [details]
Patch
The change looks trivial and making sense. - A simple renaming from [CustomConstructFunction] to [JSCustomConstructor]. - Addition of [CustomConstructor] for a shorthand for JSCustomConstructor + V8CustomConstructor. I'd like to r+ this later but a quick glance from an expert would be appreciated. Comment on attachment 109137 [details]
Patch
Looks like good clean-up. Possible to split into a few patches but makes sense as-is. No change to test IDL files/output?
Created attachment 109912 [details]
rebased patch for commit
Created attachment 109913 [details]
rebased patch for commit
(In reply to comment #3) > (From update of attachment 109137 [details]) > Looks like good clean-up. Possible to split into a few patches but makes sense as-is. No change to test IDL files/output? Dominic: No change to test IDL files, since they have an [Constructor] IDL and thus do not have an IDL for custom constructor. Comment on attachment 109913 [details] rebased patch for commit Clearing flags on attachment: 109913 Committed r96788: <http://trac.webkit.org/changeset/96788> |