|Summary:||DFG operation calls should be stdcall in Linux JSVALUE32_64 DFG JIT|
|Product:||WebKit||Reporter:||Yuqiang Xian <yuqiang.xian>|
|Version:||528+ (Nightly build)|
|Bug Depends on:||69413|
Description Yuqiang Xian 2011-09-28 20:42:25 PDT
With the STDCALL prefix, on Linux a function pointer is not implicitly converted to a FunctionPtr obj.
Comment 2 Gavin Barraclough 2011-09-28 23:59:31 PDT
Comment on attachment 109118 [details] the patch Looks like this patch is pre r96293, is there still a problem post-r96293? I don't think we want to take this change. We should be able to give FunctionPtr an appropriate set of constructors. If Linux defaults to stdcall, it is possible that the '#if CPU(X86) && COMPILER(GCC)' check in DFGOperations.h should be '#if CALLING_CONVENTION_IS_CDECL'. We should be able to fix the problem without littering the JIT with explicit constructor calls.
Comment 3 Yuqiang Xian 2011-09-29 00:06:17 PDT
Hi Gavin, Linux also defaults to cdecl. And surely we expects stdcall for JSValue32_64 DFG operations (which was a bug in previous code).
Comment 4 Yuqiang Xian 2011-09-29 05:07:57 PDT
Created attachment 109153 [details] patch This patch fixed the stdcall FunctionPtr constructors issue on Linux.
Comment 5 Geoffrey Garen 2011-09-29 12:09:35 PDT
Comment 6 Gavin Barraclough 2011-09-29 12:35:32 PDT
I think stdcall is only a convention in windows, so per geoff's comments I'm going to make this !PLATFORM(WINDOWS), r+ & land.