Bug 69056 – Check behavior of tabindex attribute with a large number

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Kent Tamura]

Bug 68981 exposed that we had never checked overflow of the attribute value.

[Kent Tamura]

Created attachment 109444 [details]
Patch

[Daniel Bates]

Comment on attachment 109444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109444&action=review

> LayoutTests/fast/dom/tabindex-defaults.html:11
> +<div id="console"></div>
> +
> +<div id=container>

Nit: This patch is inconsistent in its use of quotes around attribute values. I suggest picking one style for consistency. For example, on line 9 you put quotes around the attribute value of id, but on line 10 you don't. Similar inconsistencies can be seen in the rest of the HTML markup in this file.

> LayoutTests/fast/dom/tabindex-defaults.html:31
> +var anchor = document.getElementById('a1');
> +var button = document.getElementById('b1');
> +var input = document.getElementById('i1');
> +var select = document.getElementById('s1');
> +var textarea = document.getElementById('t1');
> +var editableDiv = document.getElementById('e1');
> +var normalDiv = document.getElementById('u1');

This is fine as-is. For your consideration, I suggest renaming the ids of the elements to match these variable names. That is, rename "a1" to "anchor", rename "b1" to "button", and so forth.

[Kent Tamura]

Committed r98075: <http://trac.webkit.org/changeset/98075>

[Kent Tamura]

(In reply to comment #2)
> (From update of attachment 109444 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109444&action=review

Thank you for your comments.  I update the patch for your comments, and landed it.