Bug 69054

Summary:

JSVALUE32_64 DFG JIT failed to be built on 32-bit Linux due to incorrect overloaded OpInfo constructor

Product:

WebKit

Reporter:

Yuqiang Xian <yuqiang.xian>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none

Description Yuqiang Xian 2011-09-28 18:16:45 PDT

size_t is equal to uint32_t on most 32-bit platforms, except for Mac OS.

Comment 1 Yuqiang Xian 2011-09-28 18:20:00 PDT

Created attachment 109110 [details]
proposed patch

Comment 2 Gavin Barraclough 2011-09-28 23:46:42 PDT

Comment on attachment 109110 [details]
proposed patch

Maybe we should just do away with this constructor - could be worth examining it's uses, I think in many cases the arguments might make more sense as size_t's (e.g. subscripts to arrays in CodeBlock).  But seems sensible for now.

Comment 3 WebKit Review Bot 2011-09-29 00:51:55 PDT

Comment on attachment 109110 [details]
proposed patch

Clearing flags on attachment: 109110

Committed r96309: <http://trac.webkit.org/changeset/96309>

Comment 4 WebKit Review Bot 2011-09-29 00:51:59 PDT

All reviewed patches have been landed.  Closing bug.