Bug 69054 - JSVALUE32_64 DFG JIT failed to be built on 32-bit Linux due to incorrect overloaded OpInfo constructor
Summary: JSVALUE32_64 DFG JIT failed to be built on 32-bit Linux due to incorrect over...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-28 18:16 PDT by Yuqiang Xian
Modified: 2011-09-29 00:51 PDT (History)
2 users (show)

See Also:

Attachments
proposed patch (1.36 KB, patch)
2011-09-28 18:20 PDT, Yuqiang Xian 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuqiang Xian 2011-09-28 18:16:45 PDT 
size_t is equal to uint32_t on most 32-bit platforms, except for Mac OS.
Comment 1 Yuqiang Xian 2011-09-28 18:20:00 PDT 
Created attachment 109110 [details]
proposed patch
Comment 2 Gavin Barraclough 2011-09-28 23:46:42 PDT 
Comment on attachment 109110 [details]
proposed patch

Maybe we should just do away with this constructor - could be worth examining it's uses, I think in many cases the arguments might make more sense as size_t's (e.g. subscripts to arrays in CodeBlock).  But seems sensible for now.
Comment 3 WebKit Review Bot 2011-09-29 00:51:55 PDT 
Comment on attachment 109110 [details]
proposed patch

Clearing flags on attachment: 109110

Committed r96309: <http://trac.webkit.org/changeset/96309>
Comment 4 WebKit Review Bot 2011-09-29 00:51:59 PDT 
All reviewed patches have been landed.  Closing bug.