Bug 69033

Summary: Complex spaces with synthetic bold are too wide
Product: WebKit Reporter: Ned Holbrook <ned>
Component: TextAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, mitz, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed changes. mitz: review+, webkit.review.bot: commit-queue-

Ned Holbrook
Reported 2011-09-28 15:07:48 PDT
ComplexTextController doubly applies space characters’ synthetic bold offset. This is because adjustGlyphsAndAdvances() calls fontData->spaceWidth() [which comes from SimpleFontData::platformWidthForGlyph() and thus includes m_syntheticBoldOffset] but then proceeds to unconditionally adds fontData->syntheticBoldOffset().
Attachments
Proposed changes. (94.88 KB, patch)
2011-09-28 16:54 PDT, Ned Holbrook 		mitz: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ned Holbrook
Comment 1 2011-09-28 15:08:58 PDT
UniscribeController::shapeAndPlaceItem() does the same thing, so I’ll apply a blind fix to it at the same time.
Ned Holbrook
Comment 2 2011-09-28 16:54:34 PDT
Created attachment 109092 [details] Proposed changes.
Ned Holbrook
Comment 3 2011-09-28 17:20:05 PDT
I'm not sure why my patch failed the style queue since it succeeds on my machine with r96265.
WebKit Review Bot
Comment 4 2011-09-28 17:49:04 PDT
Comment on attachment 109092 [details] Proposed changes. Attachment 109092 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9884668 New failing tests: fast/text/complex-synthetic-bold-space-width.html
mitz
Comment 5 2011-09-30 10:05:56 PDT
Landed in <http://trac.webkit.org/r96404>.
Note You need to log in before you can comment on or make changes to this bug.