Summary: | [chromium] Only initiate the beginFrameAndCommit sequence if a commit has been requested | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||||
Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | enne, husky, kbr, nduca, vangelis, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
James Robinson
2011-09-27 20:31:24 PDT
Created attachment 108954 [details]
Patch
With this patch the CCLayerTreeHost* tests pass with use_threaded_compositing=1 in debug. Comment on attachment 108954 [details]
Patch
Gah this is clearly wrong - m_commitRequested can only be accessed from the main thread. Will update...
Yes, seemed that you should be looking at the commitRequested argument. Created attachment 108955 [details]
Patch
Comment on attachment 108955 [details]
Patch
That looks better. r=me
Right you are, Ken. Thanks. Comment on attachment 108955 [details] Patch Clearing flags on attachment: 108955 Committed r96185: <http://trac.webkit.org/changeset/96185> All reviewed patches have been landed. Closing bug. |