Bug 68967

Summary: [chromium] Only initiate the beginFrameAndCommit sequence if a commit has been requested
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, husky, kbr, nduca, vangelis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

James Robinson
Reported 2011-09-27 20:31:24 PDT
[chromium] Only initiate the beginFrameAndCommit sequence if a commit has been requested
Attachments
Patch (1.88 KB, patch)
2011-09-27 20:32 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (1.88 KB, patch)
2011-09-27 20:45 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2011-09-27 20:32:27 PDT
Created attachment 108954 [details] Patch
James Robinson
Comment 2 2011-09-27 20:33:17 PDT
With this patch the CCLayerTreeHost* tests pass with use_threaded_compositing=1 in debug.
James Robinson
Comment 3 2011-09-27 20:44:16 PDT
Comment on attachment 108954 [details] Patch Gah this is clearly wrong - m_commitRequested can only be accessed from the main thread. Will update...
Kenneth Russell
Comment 4 2011-09-27 20:45:22 PDT
Yes, seemed that you should be looking at the commitRequested argument.
James Robinson
Comment 5 2011-09-27 20:45:47 PDT
Created attachment 108955 [details] Patch
Kenneth Russell
Comment 6 2011-09-27 20:46:35 PDT
Comment on attachment 108955 [details] Patch That looks better. r=me
James Robinson
Comment 7 2011-09-27 20:49:40 PDT
Right you are, Ken. Thanks.
WebKit Review Bot
Comment 8 2011-09-27 21:02:30 PDT
Comment on attachment 108955 [details] Patch Clearing flags on attachment: 108955 Committed r96185: <http://trac.webkit.org/changeset/96185>
WebKit Review Bot
Comment 9 2011-09-27 21:02:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.