Bug 68950

Summary:

watchlist: Add support for cc and message rules.

Product:

WebKit

Reporter:

David Levin <levin>

Component:

Tools / Tests

Assignee:

David Levin <levin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

68822

Attachments:

Description	Flags
Patch	abarth: review+

Description David Levin 2011-09-27 16:15:44 PDT

This is to list emails or messages to add to a bug when a definition matches a patch.

Comment 1 David Levin 2011-09-27 16:22:33 PDT

Created attachment 108925 [details]
Patch

Comment 2 Adam Barth 2011-09-27 16:27:48 PDT

Comment on attachment 108925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108925&action=review

> Tools/Scripts/webkitpy/common/watchlist/watchlist.py:81
> +            'messages':  self.determine_messages(definitions), }

PEP8 would tell you to put the } on the next line.

Comment 3 David Levin 2011-09-27 16:42:40 PDT

Committed as http://trac.webkit.org/changeset/96170 

(And addressed Adam's comment.)