Bug 68943 (premultiplyAlpha)

Summary: Missing initialization of member in ImageFrameQt class
Product: WebKit Reporter: Adenilson Cavalcanti Silva <savagobr>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P4    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Initialize premultiplyAlpha and copy in operator
none
Patch
none
Initialize premultiplyAlpha and copy in operator plus Changelog none

Description Adenilson Cavalcanti Silva 2011-09-27 15:13:23 PDT 
While using Qt image decoder, the class member premultiplyAlpha is not being initialized or copied by assignment operator (thus at best depending on compiler/platform or simply random).

This patch fixes this issue.

ps: the same behavior is implemented in Skia port and grob branch.
Comment 1 Adenilson Cavalcanti Silva 2011-09-27 15:14:48 PDT 
Created attachment 108910 [details]
Initialize premultiplyAlpha and copy in operator
Comment 2 Kenneth Rohde Christiansen 2011-09-27 17:04:47 PDT 
Comment on attachment 108910 [details]
Initialize premultiplyAlpha and copy in operator

r=, misses ChangeLog!
Comment 3 Adenilson Cavalcanti Silva 2011-09-27 20:07:24 PDT 
Created attachment 108952 [details]
Patch
Comment 4 Adenilson Cavalcanti Silva 2011-09-27 20:10:34 PDT 
Created attachment 108953 [details]
Initialize premultiplyAlpha and copy in operator plus Changelog
Comment 5 Noam Rosenthal 2011-09-27 23:26:13 PDT 
Comment on attachment 108953 [details]
Initialize premultiplyAlpha and copy in operator plus Changelog

It's already reviewed, you don't need to r? it again.
Comment 6 WebKit Review Bot 2011-09-28 00:21:44 PDT 
Comment on attachment 108953 [details]
Initialize premultiplyAlpha and copy in operator plus Changelog

Clearing flags on attachment: 108953

Committed r96196: <http://trac.webkit.org/changeset/96196>
Comment 7 WebKit Review Bot 2011-09-28 00:21:49 PDT 
All reviewed patches have been landed.  Closing bug.