Bug 68941

Summary: Fix potential SVG performance regression (over-invalidation of caches) from 96052.
Product: WebKit Reporter: Tim Horton <thorton>
Component: SVGAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, webkit.review.bot, zimmermann
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Description Tim Horton 2011-09-27 15:08:49 PDT 
Because of https://bugs.webkit.org/show_bug.cgi?id=68457, I added code to drop objects from the SVGResources cache when the target changes. It turns out (validating Niko and Rob's concerns in the aforementioned bug) that there's no need to do this for any case (that I've come up with so far) except filters, as filters are the only resource which makes use of its targets style.

So, we should only do the cache drop if we have a filter.

Patch coming soon.
Comment 1 Radar WebKit Bug Importer 2011-09-27 15:09:06 PDT 
<rdar://problem/10196224>
Comment 2 Tim Horton 2011-09-27 15:09:21 PDT 
s/Rob/Dirk/
Comment 3 Tim Horton 2011-09-27 15:26:23 PDT 
Created attachment 108913 [details]
patch
Comment 4 Zoltan Herczeg 2011-09-27 23:47:06 PDT 
Comment on attachment 108913 [details]
patch

LGTM
Comment 5 WebKit Review Bot 2011-09-28 01:05:55 PDT 
Comment on attachment 108913 [details]
patch

Clearing flags on attachment: 108913

Committed r96203: <http://trac.webkit.org/changeset/96203>
Comment 6 WebKit Review Bot 2011-09-28 01:05:59 PDT 
All reviewed patches have been landed.  Closing bug.