Bug 68930

Summary: Web Inspector: Refactor searching in inspector, add test (fixed non regex search).
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Description Vsevolod Vlasov 2011-09-27 13:43:29 PDT 
Refactor searching in inspector, add test (+fix).
Comment 1 Vsevolod Vlasov 2011-09-27 14:59:47 PDT 
Created attachment 108906 [details]
Patch
Comment 2 Vsevolod Vlasov 2011-09-27 15:02:35 PDT 
We will need search in debugger agent as well, so moved it out of page agent.
Added test.
Fixed non regex case (added " != notFound" to condition) which is never used yet, but will probably be used for search in multiple scripts.
Comment 3 Yury Semikhatsky 2011-09-28 00:49:09 PDT 
Comment on attachment 108906 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108906&action=review

> LayoutTests/ChangeLog:3
> +        Web Inspector: Refactor searching in inspector, add test (+fix).

What is (+fix) in the title? Also the log entry should contain a description of the changes made.

> Source/WebCore/inspector/ContentSearchUtils.h:44
> +    ContentSearchUtils() { }

You may use a namespace instead.
Comment 4 Vsevolod Vlasov 2011-09-28 04:56:02 PDT 
Committed r96215: <http://trac.webkit.org/changeset/96215>