| Summary: | Add layout test for WaveShaperNode | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Rogers <crogers> | ||||
| Component: | New Bugs | Assignee: | Chris Rogers <crogers> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric.carlson, jer.noble, kbr, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Chris Rogers
2011-09-27 12:36:02 PDT
Created attachment 108883 [details]
Patch
Please see the specification for WaveShaperNode for more background: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#WaveShaperNode-section Comment on attachment 108883 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108883&action=review This looks great to me modulo one nit. These layout tests for the Web Audio API are looking really nice so far. r=me > LayoutTests/webaudio/waveshaper.html:8 > +<script type="text/javascript" src="resources/buffer-loader.js"></script> I don't think this file is needed. Comment on attachment 108883 [details] Patch Clearing flags on attachment: 108883 Committed r96182: <http://trac.webkit.org/changeset/96182> All reviewed patches have been landed. Closing bug. |