Bug 68914

Summary:

Clean up how FrameView accesses the RenderView

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Layout and Rendering

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hyatt, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Simon Fraser (smfr)

Reported 2011-09-27 10:42:23 PDT

FrameView uses several different ways to get at the frame's root RenderView, and some of the null-check, others do not. This can cause crashes (e.g. bug 68893).

Attachments
Patch (19.38 KB, patch) 2011-09-27 10:50 PDT, Simon Fraser (smfr)	sam: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2011-09-27 10:50:10 PDT

Created attachment 108868 [details] Patch

Simon Fraser (smfr)

Comment 2 2011-09-27 10:54:12 PDT

http://trac.webkit.org/changeset/96130

Note You need to log in before you can comment on or make changes to this bug.