Bug 68883

Summary: Implement a MessageEvent constructor for JSC
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, dominicc, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67824    
Attachments:
Description Flags
Patch
none
Rebased patch
abarth: review+
patch for commit none

Kentaro Hara
Reported 2011-09-27 02:45:29 PDT
MessageEvent should have a constructor (Spec: http://www.whatwg.org/specs/web-apps/current-work/#messageevent). After this patch is landed, I will add the MessageEvent constructor for V8 as a follow-up patch.
Attachments
Patch (38.95 KB, patch)
2011-09-27 03:16 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Rebased patch (39.01 KB, patch)
2011-09-27 05:59 PDT, Kentaro Hara 		abarth: review+
DetailsFormatted DiffDiff
patch for commit (38.94 KB, patch)
2011-09-27 18:24 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-09-27 03:16:08 PDT
Created attachment 108821 [details] Patch
WebKit Review Bot
Comment 2 2011-09-27 03:20:26 PDT
Attachment 108821 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 ERROR: FAILURES FOR <lucid, x86_64, release, cpu> ERROR: Line:3791 Path does not exist. ast/canvas/webgl/premultiplyalpha-test.html LayoutTests/platform/chromium/test_expectations.txt:3791: Path does not exist. ast/canvas/webgl/premultiplyalpha-test.html [test/expectations] [2] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kentaro Hara
Comment 3 2011-09-27 05:59:06 PDT
Created attachment 108832 [details] Rebased patch
Kentaro Hara
Comment 4 2011-09-27 18:24:26 PDT
Created attachment 108947 [details] patch for commit
WebKit Review Bot
Comment 5 2011-09-27 19:01:24 PDT
Comment on attachment 108947 [details] patch for commit Clearing flags on attachment: 108947 Committed r96179: <http://trac.webkit.org/changeset/96179>
Note You need to log in before you can comment on or make changes to this bug.