Summary: | watchlist: Change watchlistparser.py to be class based. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Levin <levin> | ||||
Component: | Tools / Tests | Assignee: | David Levin <levin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 68822 | ||||||
Attachments: |
|
Description
David Levin
2011-09-26 22:57:00 PDT
Created attachment 108790 [details]
Patch
Comment on attachment 108790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108790&action=review Thanks. I've had to learn this the hard way. Basically it becomes impossible to test static module funtions. Adding them into a class makes it super easy to have the class hold an Executive/FileSystem/User or other mockable object if needed. > Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py:33 > _INVALID_DEFINITION_NAME_REGEX = r'\|' I bet you want to make these class members now too. > Tools/Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:52 > + watch_list_parser = WatchListParser() You could have a setUp which allocates self.parser = WatchListParser() if you prefer. Changed as suggested. Committed as http://trac.webkit.org/changeset/96115. |