Bug 68869

Summary: watchlist: Change watchlistparser.py to be class based.
Product: WebKit Reporter: David Levin <levin>
Component: Tools / TestsAssignee: David Levin <levin>
Severity: Normal CC: abarth, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 68822    
Description Flags
Patch eric: review+, levin: commit-queue-

Description David Levin 2011-09-26 22:57:00 PDT
Instead of function based.
Comment 1 David Levin 2011-09-26 23:01:25 PDT
Created attachment 108790 [details]
Comment 2 Eric Seidel (no email) 2011-09-27 00:20:58 PDT
Comment on attachment 108790 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=108790&action=review

Thanks.  I've had to learn this the hard way.  Basically it becomes impossible to test static module funtions.  Adding them into a class makes it super easy to have the class hold an Executive/FileSystem/User or other mockable object if needed.

> Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py:33

I bet you want to make these class members now too.

> Tools/Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:52
> +        watch_list_parser = WatchListParser()

You could have a setUp which allocates self.parser = WatchListParser() if you prefer.
Comment 3 David Levin 2011-09-27 08:52:06 PDT
Changed as suggested.

Committed as http://trac.webkit.org/changeset/96115.