Bug 68867

Summary: [EFL] Remove *void* parameter in internal functions
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, leandro, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 68209    
Attachments:
Description Flags
Patch none

Description Gyuyoung Kim 2011-09-26 22:05:54 PDT 
As one among efforts which are more compliant with WebKit coding style, we need to remove *void* parameter in internal functions. But, it looks we need to discuss to remove *void* parameter in public functions further.
Comment 1 Lucas De Marchi 2011-09-27 02:36:13 PDT 
(In reply to comment #0)
> As one among efforts which are more compliant with WebKit coding style, we need to remove *void* parameter in internal functions. But, it looks we need to discuss to remove *void* parameter in public functions further.

We *can't* remove void on public headers. Please, do it only for internal ones.
Comment 2 Gyuyoung Kim 2011-09-27 20:46:58 PDT 
Created attachment 108956 [details]
Patch
Comment 3 Gyuyoung Kim 2011-09-27 20:47:59 PDT 
Ok, this patch is only related to internal functions.
Comment 4 Lucas De Marchi 2011-09-27 21:44:43 PDT 
Comment on attachment 108956 [details]
Patch

informal r+
Comment 5 WebKit Review Bot 2011-09-28 05:34:27 PDT 
Comment on attachment 108956 [details]
Patch

Clearing flags on attachment: 108956

Committed r96217: <http://trac.webkit.org/changeset/96217>
Comment 6 WebKit Review Bot 2011-09-28 05:34:31 PDT 
All reviewed patches have been landed.  Closing bug.