Bug 68837

Summary: [GTK] Do not ignore 'Replaceable' attributes in the DOM bindings
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: sam, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
replaceable.diff none

Xan Lopez
Reported 2011-09-26 14:46:59 PDT
We are ignoring all attributes with this tag, but we shouldn't. Worst case they should be readable, which is what this patch does. In the future we should probably actually allow them to be replaced, with some kind of custom code.
Attachments
replaceable.diff (3.53 KB, patch)
2011-09-26 15:10 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2011-09-26 15:10:52 PDT
Created attachment 108729 [details] replaceable.diff
Martin Robinson
Comment 2 2011-09-26 15:13:31 PDT
Comment on attachment 108729 [details] replaceable.diff Looks good. Better open abug for the the FIXME.
Xan Lopez
Comment 3 2011-09-26 15:27:32 PDT
Comment on attachment 108729 [details] replaceable.diff Clearing flags on attachment: 108729 Committed r96009: <http://trac.webkit.org/changeset/96009>
Xan Lopez
Comment 4 2011-09-26 15:27:38 PDT
All reviewed patches have been landed. Closing bug.
Sam Weinig
Comment 5 2011-09-26 21:21:19 PDT
Replaceable (as far as I can remember) is really is only there to support the fact that the DOMWindow is also the global object, so it probably doesn't makes sense outside of JavaScript.
Note You need to log in before you can comment on or make changes to this bug.