Bug 68818

Summary: IndexedDB: Second half of IDBFactory.getDatabaseNames implementation
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: dgrogan, hans, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Joshua Bell
Reported 2011-09-26 11:38:15 PDT
IndexedDB: Second half of IDBFactory.getDatabaseNames implementation
Attachments
Patch (36.40 KB, patch)
2011-09-26 11:41 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch (36.42 KB, patch)
2011-09-26 14:44 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2011-09-26 11:41:50 PDT
Created attachment 108697 [details] Patch
Joshua Bell
Comment 2 2011-09-26 11:44:55 PDT
First half was landed as https://bugs.webkit.org/show_bug.cgi?id=68037 - initial patches there contained both halves, which received review.
David Grogan
Comment 3 2011-09-26 11:59:13 PDT
Comment on attachment 108697 [details] Patch LGTM, assuming it's unchanged from the other bug.
Joshua Bell
Comment 4 2011-09-26 12:35:30 PDT
Tony - another one for you to poke at with a stick.
Tony Chang
Comment 5 2011-09-26 13:49:03 PDT
Comment on attachment 108697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108697&action=review > Source/WebCore/storage/IDBFactoryBackendImpl.cpp:63 > + > + Nit: Did you mean to add this whitespace?
Joshua Bell
Comment 6 2011-09-26 14:44:33 PDT
Created attachment 108726 [details] Patch
WebKit Review Bot
Comment 7 2011-09-26 17:42:09 PDT
Comment on attachment 108726 [details] Patch Clearing flags on attachment: 108726 Committed r96054: <http://trac.webkit.org/changeset/96054>
WebKit Review Bot
Comment 8 2011-09-26 17:42:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.