Bug 68809

Summary: IconDatabase::syncThreadMainLoop can assert if wakeSyncThread is called before thread starts executing
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: WebCore Misc.Assignee: Mark Rowe (bdash) <mrowe>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, dino, mitz, simon.fraser
Priority: P2 Keywords: Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Untested patch
none
Patch v1 andersca: review+

Mark Rowe (bdash)
Reported 2011-09-26 09:40:27 PDT
As in summary. This is a regression from r95929 / bug 68783.
Attachments
Untested patch (874 bytes, patch)
2011-09-26 09:42 PDT, Mark Rowe (bdash)
no flags
Patch v1 (3.12 KB, patch)
2011-09-26 10:03 PDT, Mark Rowe (bdash)
andersca: review+
Mark Rowe (bdash)
Comment 1 2011-09-26 09:42:43 PDT
Created attachment 108679 [details] Untested patch This is an untested patch that I believe will address the issue. I’m putting it up as it may be a few hours before I’m able to test the patch, and it may be useful for anyone being troubled by the assertion.
Mark Rowe (bdash)
Comment 2 2011-09-26 10:03:22 PDT
Created attachment 108683 [details] Patch v1 Dan says that this addressed the issue for him, so I’m putting it up for review.
Mark Rowe (bdash)
Comment 3 2011-09-26 10:35:25 PDT
Fixed in r95961.
Note You need to log in before you can comment on or make changes to this bug.