Bug 68807

Summary: [skia] need rebaseline after the next skia roll -- improvements to xfermodes on gpu
Product: WebKit Reporter: Mike Reed <reed>
Component: New BugsAssignee: Mike Reed <reed>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, kbr, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Mike Reed
Reported 2011-09-26 09:08:09 PDT
[skia] need rebaseline after the next skia roll -- improvedments to xfermodes on gpu
Attachments
Patch (1.43 KB, patch)
2011-09-26 09:08 PDT, Mike Reed 		no flags
DetailsFormatted DiffDiff
Patch (1.45 KB, patch)
2011-09-26 09:58 PDT, Mike Reed 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike Reed
Comment 1 2011-09-26 09:08:49 PDT
Created attachment 108674 [details] Patch
James Robinson
Comment 2 2011-09-26 09:30:43 PDT
Comment on attachment 108674 [details] Patch They only need a rebaseline on linux? What about mac or windows? If they only need a rebaseline in GPU mode, you can add the 'GPU' modifier.
Mike Reed
Comment 3 2011-09-26 09:58:37 PDT
Created attachment 108682 [details] Patch
Mike Reed
Comment 4 2011-09-26 09:59:06 PDT
updated expectations to specify GPU
James Robinson
Comment 5 2011-09-26 13:53:28 PDT
This says GPU but I still have no idea why this would be linux-specific. Mind explaining that?
Stephen White
Comment 6 2011-09-26 14:02:47 PDT
Comment on attachment 108682 [details] Patch Looks good. r=me
Stephen White
Comment 7 2011-09-26 14:03:57 PDT
Sorry, didn't see James's comments until I r+'ed it. Well, I leave it up to your discretion. If you break it, you bought it. :)
Mike Reed
Comment 8 2011-09-26 14:16:16 PDT
I ran DRT locally on windows and linux, and only saw the problem on linux. I can be more conservative next time, and just say GPU.
James Robinson
Comment 9 2011-09-26 14:25:38 PDT
(In reply to comment #8) > I ran DRT locally on windows and linux, and only saw the problem on linux. I can be more conservative next time, and just say GPU. OK, that's fine. There's no way for me to know that you had done that unless you let me know somehow, or say so in the ChangeLog.
Mike Reed
Comment 10 2011-09-26 14:32:52 PDT
I wouldn't have know which ones to rebaseline, if I hadn't run locally. That said, it is odd that I didn't see any failures when I ran on Windows. Who knows, I may have just screwed up and missed them (gulp).
James Robinson
Comment 11 2011-09-26 14:50:31 PDT
¯\(°_o)/¯ let's see what the bots says, then.
WebKit Review Bot
Comment 12 2011-09-26 15:20:11 PDT
Comment on attachment 108682 [details] Patch Clearing flags on attachment: 108682 Committed r96006: <http://trac.webkit.org/changeset/96006>
WebKit Review Bot
Comment 13 2011-09-26 15:20:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.