| Summary: | Web Inspector: introduce protocol backwards compatibility validator. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Pavel Feldman
2011-09-26 06:34:15 PDT
Created attachment 108660 [details]
Patch
Created attachment 108663 [details]
[Patch] Same with the draft-01 to validate against.
Comment on attachment 108663 [details] [Patch] Same with the draft-01 to validate against. View in context: https://bugs.webkit.org/attachment.cgi?id=108663&action=review > Source/WebCore/inspector/validate-protocol-compatibility:31 > + Please add a definition of what valid protocol change is, also would be nice to have several tests for invalid cases. > Source/WebCore/inspector/validate-protocol-compatibility:162 > + json_string = json_string.replace(": true", ": True") what about :true and :false cases(without whitespace)? > Source/WebCore/inspector/validate-protocol-compatibility:168 > + print "Usage: validate-protocol-compatibility Inspector.draft-01.json Inspector.json" validate-protocol-compatibility -> sys.argv[0] Created attachment 108667 [details]
[Patch] Review comments addressed
Comment on attachment 108667 [details]
[Patch] Review comments addressed
Please add inline self-test as we agreed offline.
Committed r95953: <http://trac.webkit.org/changeset/95953> |