Bug 68800

Summary: Web Inspector: introduce protocol backwards compatibility validator.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
[Patch] Same with the draft-01 to validate against.
[Patch] Review comments addressed yurys: review+

Description Pavel Feldman 2011-09-26 06:34:15 PDT
Patch to follow.
Comment 1 Pavel Feldman 2011-09-26 06:40:25 PDT
Created attachment 108660 [details]
Comment 2 Pavel Feldman 2011-09-26 06:59:42 PDT
Created attachment 108663 [details]
[Patch] Same with the draft-01 to validate against.
Comment 3 Yury Semikhatsky 2011-09-26 07:26:00 PDT
Comment on attachment 108663 [details]
[Patch] Same with the draft-01 to validate against.

View in context: https://bugs.webkit.org/attachment.cgi?id=108663&action=review

> Source/WebCore/inspector/validate-protocol-compatibility:31
> +

Please add a definition of what valid protocol change is, also would be nice to have several tests for invalid cases.

> Source/WebCore/inspector/validate-protocol-compatibility:162
> +    json_string = json_string.replace(": true", ": True")

what about :true and :false cases(without whitespace)?

> Source/WebCore/inspector/validate-protocol-compatibility:168
> +        print "Usage: validate-protocol-compatibility Inspector.draft-01.json Inspector.json"

validate-protocol-compatibility -> sys.argv[0]
Comment 4 Pavel Feldman 2011-09-26 07:54:22 PDT
Created attachment 108667 [details]
[Patch] Review comments addressed
Comment 5 Yury Semikhatsky 2011-09-26 08:03:23 PDT
Comment on attachment 108667 [details]
[Patch] Review comments addressed

Please add inline self-test as we agreed offline.
Comment 6 Pavel Feldman 2011-09-26 08:28:53 PDT
Committed r95953: <http://trac.webkit.org/changeset/95953>