Summary: | REGRESSION (r95747): Activating the web inspector causes the web process to be killed | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Rowe (bdash) <mrowe> | ||||
Component: | WebKit2 | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, andersca, ap, ossy, webkit.review.bot | ||||
Priority: | P1 | Keywords: | Regression | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mark Rowe (bdash)
2011-09-24 13:22:45 PDT
The way we solve this in Chromium is to use a URL scheme other that "file" for the web inspector. For example, we used the scheme "inspector" at some point. Now, I think we use "chrome", which is the scheme we use for a bunch of browser-provided HTML UI. I’m pretty sure this is just an oversight in r95747 and that the code path that shows the inspector simply isn’t making the necessary call so that the MESSAGE_CHECK_URL call knows that the UI process initiated the load of the inspector. Yep, that's another approach to solving this problem. As Mark says, WebInspectorProxy::createInspectorPage() should add WebCore resources folder to WebProcessProxy::m_localPathsWithAssumedReadAccess. I'll work on this ASAP (which might be Monday). Created attachment 108704 [details]
proposed fix
Comment on attachment 108704 [details] proposed fix Clearing flags on attachment: 108704 Committed r96014: <http://trac.webkit.org/changeset/96014> All reviewed patches have been landed. Closing bug. Qt-WK2 buildfix landed in http://trac.webkit.org/changeset/96067 |