Bug 68743

Summary: Canvas security checks show up on HTML5GamingTest benchmark
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bsalomon, japhet, mrowe, reed, tomhudson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2011-09-23 16:02:21 PDT
Canvas security checks show up on HTML5GamingTest benchmark
Attachments
Patch (3.81 KB, patch)
2011-09-23 16:05 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (3.73 KB, patch)
2011-09-23 17:23 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-09-23 16:05:14 PDT
Created attachment 108552 [details] Patch
Alexey Proskuryakov
Comment 2 2011-09-23 16:51:08 PDT
Comment on attachment 108552 [details] Patch Is this code main thread only? Another function in this file uses AtomicallyInitializedStatic, making me suspicious of DEFINE_STATIC_LOCAL use.
Adam Barth
Comment 3 2011-09-23 17:23:52 PDT
Created attachment 108565 [details] Patch
WebKit Review Bot
Comment 4 2011-09-23 20:51:04 PDT
Comment on attachment 108565 [details] Patch Clearing flags on attachment: 108565 Committed r95900: <http://trac.webkit.org/changeset/95900>
WebKit Review Bot
Comment 5 2011-09-23 20:51:08 PDT
All reviewed patches have been landed. Closing bug.
Mark Rowe (bdash)
Comment 6 2011-09-23 22:04:53 PDT
This broke all of the Mac builds because it introduced an exit-time destructor. Please keep an eye on the build bots when landing changes in the future.
Adam Barth
Comment 7 2011-09-24 09:38:52 PDT
(In reply to comment #6) > This broke all of the Mac builds because it introduced an exit-time destructor. Please keep an eye on the build bots when landing changes in the future. Thanks for fixing the build for me.
Note You need to log in before you can comment on or make changes to this bug.