Summary: | Add static version of JSCell::getCallData | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Hahnenberg <mhahnenberg> | ||||||
Component: | JavaScriptCore | Assignee: | Mark Hahnenberg <mhahnenberg> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 67690 | ||||||||
Attachments: |
|
Description
Mark Hahnenberg
2011-09-23 15:50:59 PDT
Created attachment 108609 [details]
Patch
Comment on attachment 108609 [details] Patch Attachment 108609 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9842812 Comment on attachment 108609 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108609&action=review One thing that’s bad about the new functions is that they all have unchecked type casts in them. It makes me wish there was some way to check the types in all those cases are correct. Looks like this did not build on Qt. r=me if you address the Qt build failure > Source/JavaScriptCore/ChangeLog:13 > + able to more easily store and refer to them in our custom vtable since normal I’d say in our “method table” not our “custom viable”. > Source/JavaScriptCore/ChangeLog:15 > + impossible to store them generically in ClassInfo. I think I’d say something more like this: Function pointers are smaller and more efficient to call than pointers to member functions, and using static member functions allows us to use function pointers. Created attachment 108727 [details]
Patch
Comment on attachment 108727 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108727&action=review > Source/JavaScriptGlue/ChangeLog:14 > + can be represented as function pointers rather than pointers to member methods, and > + function pointers are smaller and faster to call than pointers to member methods. The term is "member functions", not "member methods". Committed r96164: <http://trac.webkit.org/changeset/96164> |