Bug 68723

Summary:

Resolve opcodes should have value profiling.

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, fpizlo, oliver

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

68677

Attachments:

Description	Flags
the patch	oliver: review+

Filip Pizlo

Reported 2011-09-23 13:29:18 PDT

We want all operations that load values from the heap to have value profiling. The Resolve opcodes are the last ones that don't.

Attachments
the patch (13.71 KB, patch) 2011-09-23 15:27 PDT, Filip Pizlo	oliver: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2011-09-23 15:27:13 PDT

Created attachment 108546 [details] the patch This is pretty much performance neutral. There is a spurious, but totally reproducible, 0.3% slow-down in V8 on my MacBook Pro. There are similarly sized, though not as reproducible, speed-ups in SunSpider and Kraken. I checked and none of the benchmarks that have performance variations make any use of any of the affected opcodes. So these are just insignificant variations due to code layout.

Filip Pizlo

Comment 2 2011-09-23 16:27:36 PDT

Landed in r95887.

Note You need to log in before you can comment on or make changes to this bug.