Bug 68714

Summary: Consider increasing the maximal rowspan value
Product: WebKit Reporter: Boris Zbarsky <bzbarsky>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ahmad.saleem792, ap, bfulgham, cdumez, fsamuel, jchaffraix, mmaxfield, pravind.2k4, rniwa, webkit.bugzilla
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Example of the issue (taken from downstream Chromium bug) none

Boris Zbarsky
Reported 2011-09-23 12:23:25 PDT
This is currently set at 8190 because that's what Gecko had it set to. We're probably increasing it to 65534 in Gecko because there are in fact use cases that want pretty large rowspans; see https://bugzilla.mozilla.org/show_bug.cgi?id=688405
Attachments
Example of the issue (taken from downstream Chromium bug) (198.23 KB, text/html)
2012-10-05 17:32 PDT, Julien Chaffraix 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2012-10-05 17:29:52 PDT
*** Bug 96849 has been marked as a duplicate of this bug. ***
Julien Chaffraix
Comment 2 2012-10-05 17:32:16 PDT
Created attachment 167423 [details] Example of the issue (taken from downstream Chromium bug) Copying relevant data from the duplicated bug: FF currently uses 2^16 - 2 as the max value for rowspan. This value is chosen due a limitation in there impl of cell maps. http://mxr.mozilla.org/mozilla-central/source/layout/tables/celldata.h#17
Pravin D
Comment 3 2012-10-08 00:09:20 PDT
@Julien If we are planning to increase the rowspan limit, what are the relevant factors that needs to be considered ?
Ahmad Saleem
Comment 4 2022-08-12 09:21:40 PDT
From attached test case - all browsers (Chrome Canary 106, Firefox Nightly 105 and Safari Technical Preview 151) show result of 8500 rows. Since all browsers are matching these days, I am going to mark this as "RESOLVED WONTFIX", if it is still an issue, please reopen it. Thanks!
Alexey Proskuryakov
Comment 5 2022-08-20 15:31:33 PDT
This is not the best test, as is only tests up to 8500. In fact, everyone is aligned at 65534 now. One thing I noticed was this code still in WebKit: Source/WebCore/mathml/MathMLElement.cpp: static const unsigned maxRowspan = 8190; // This constant comes from HTMLTableCellElement. I don't know if this is wrong or important, someone is encouraged to file a new bug if this suggests an actual problem. *** This bug has been marked as a duplicate of bug 171322 ***
Note You need to log in before you can comment on or make changes to this bug.