Bug 68704

Summary: Implement op_resolve_global in the DFG JIT
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix oliver: review+

Gavin Barraclough
Reported 2011-09-23 10:38:16 PDT
This is performance neutral, but increases coverage.
Attachments
Fix (8.86 KB, patch)
2011-09-23 10:39 PDT, Gavin Barraclough 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2011-09-23 10:39:51 PDT
Created attachment 108490 [details] Fix
Oliver Hunt
Comment 2 2011-09-23 10:52:42 PDT
Comment on attachment 108490 [details] Fix r=me
Mark Rowe (bdash)
Comment 3 2011-09-23 10:57:12 PDT
Comment on attachment 108490 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=108490&action=review > Source/JavaScriptCore/ChangeLog:37 > +2011-09-22 Gavin Barraclough <barraclough@apple.com> > + > + Need a short description and bug URL (OOPS!) > + > + Reviewed by NOBODY (OOPS!). > + > + * dfg/DFGByteCodeParser.cpp: > + (JSC::DFG::ByteCodeParser::ByteCodeParser): > + (JSC::DFG::ByteCodeParser::parseBlock): > + * dfg/DFGNode.h: > + (JSC::DFG::Node::hasIdentifier): > + (JSC::DFG::Node::resolveInfoIndex): > + * dfg/DFGOperations.cpp: > + * dfg/DFGOperations.h: > + * dfg/DFGSpeculativeJIT.cpp: > + (JSC::DFG::SpeculativeJIT::compile): > + I don’t think you want to include this bit.
Gavin Barraclough
Comment 4 2011-09-23 11:52:14 PDT
Opps! - yep. Fixed in r95840.
Note You need to log in before you can comment on or make changes to this bug.