| Summary: | [EFL] Add virtual method to notify user when wrapping focus | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Lucas De Marchi <lucas.de.marchi> | ||||||
| Component: | New Bugs | Assignee: | Lucas De Marchi <lucas.de.marchi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | kenneth, leandro, lucas.de.marchi, rakuco, tonikitoo | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Lucas De Marchi
2011-09-23 08:21:20 PDT
Created attachment 108484 [details]
Patch
Informal r+. CC'ing reviewers. Comment on attachment 108484 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108484&action=review Does it need API review? > Source/WebKit/efl/ewk/ewk_view.h:117 > + EWK_FOCUS_DIRECTION_BACKWARD, > + EWK_FOCUS_DIRECTION_UP, > + EWK_FOCUS_DIRECTION_DOWN, > + EWK_FOCUS_DIRECTION_LEFT, > + EWK_FOCUS_DIRECTION_RIGHT, Is it for TAB navigation. Do you need the arrow ones? (In reply to comment #4) > (From update of attachment 108484 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=108484&action=review > > Does it need API review? > > > Source/WebKit/efl/ewk/ewk_view.h:117 > > + EWK_FOCUS_DIRECTION_BACKWARD, > > + EWK_FOCUS_DIRECTION_UP, > > + EWK_FOCUS_DIRECTION_DOWN, > > + EWK_FOCUS_DIRECTION_LEFT, > > + EWK_FOCUS_DIRECTION_RIGHT, > > Is it for TAB navigation. Do you need the arrow ones? I thought we could actually wrap when going through a certain direction, but FocusController::advanceFocusDirectionally() doesn't call this function. Is it on purpose or just a missing functionality? (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 108484 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=108484&action=review > > > > Does it need API review? > > > > > Source/WebKit/efl/ewk/ewk_view.h:117 > > > + EWK_FOCUS_DIRECTION_BACKWARD, > > > + EWK_FOCUS_DIRECTION_UP, > > > + EWK_FOCUS_DIRECTION_DOWN, > > > + EWK_FOCUS_DIRECTION_LEFT, > > > + EWK_FOCUS_DIRECTION_RIGHT, > > > > Is it for TAB navigation. Do you need the arrow ones? > > I thought we could actually wrap when going through a certain direction, but FocusController::advanceFocusDirectionally() doesn't call this function. Is it on purpose or just a missing functionality? wrapping in direction navigation would not really make users happy :). Created attachment 108706 [details]
Patch
(In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > (From update of attachment 108484 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=108484&action=review > > > > > > Does it need API review? > > > > > > > Source/WebKit/efl/ewk/ewk_view.h:117 > > > > + EWK_FOCUS_DIRECTION_BACKWARD, > > > > + EWK_FOCUS_DIRECTION_UP, > > > > + EWK_FOCUS_DIRECTION_DOWN, > > > > + EWK_FOCUS_DIRECTION_LEFT, > > > > + EWK_FOCUS_DIRECTION_RIGHT, > > > > > > Is it for TAB navigation. Do you need the arrow ones? > > > > I thought we could actually wrap when going through a certain direction, but FocusController::advanceFocusDirectionally() doesn't call this function. Is it on purpose or just a missing functionality? > > wrapping in direction navigation would not really make users happy :). Ok, I uploaded a new patch then. Comment on attachment 108706 [details] Patch Clearing flags on attachment: 108706 Committed r95983: <http://trac.webkit.org/changeset/95983> All reviewed patches have been landed. Closing bug. |