update layout_tests to account for new default of use_skia=1

• Component: Tools / Tests
• Status: RESOLVED FIXED

Once the Chromium CL in http://codereview.chromium.org/8002009 is committed, Chromium will default to using the Skia graphics library on Mac (instead of Core Graphics).

This change needs to be reflected in the layout_test machinery: the default port for mac changes from chromium-cg-mac to chromium-mac.

This CL will cause some layout_tests to fail unless the aforementioned Chromium CL has been picked up as well.

Created attachment 108477 [details]
Patch

[Mihai Parparita]

(In reply to comment #0)
> This CL will cause some layout_tests to fail unless the aforementioned Chromium CL has been picked up as well.

Does this mean that you'll need to land the Chromium change first, and update this patch to also modify http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/DEPS to set chromium_rev to that revision?

(In reply to comment #2)
> (In reply to comment #0)
> > This CL will cause some layout_tests to fail unless the aforementioned Chromium CL has been picked up as well.
> 
> Does this mean that you'll need to land the Chromium change first, and update this patch to also modify http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/DEPS to set chromium_rev to that revision?

Yes, you're right, I will have to do that.

Created attachment 108498 [details]
Patch

Created attachment 108505 [details]
Patch

[Mihai Parparita]

Comment on attachment 108505 [details]
Patch

Clearing flags on attachment: 108505

Committed r95850: <http://trac.webkit.org/changeset/95850>

[Mihai Parparita]

All reviewed patches have been landed.  Closing bug.