Bug 68667

Summary: Use AffineTransform scale functions in ShadowBlur::adjustBlurRadius
Product: WebKit Reporter: Darin Adler <darin>
Component: Layout and RenderingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: jchaffraix, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 68722    
Attachments:
Description Flags
Patch none

Darin Adler
Reported 2011-09-22 17:23:31 PDT
Use AffineTransform scale functions in ShadowBlur::adjustBlurRadius
Attachments
Patch (2.47 KB, patch)
2011-09-22 17:24 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2011-09-22 17:24:51 PDT
Created attachment 108425 [details] Patch
Darin Adler
Comment 2 2011-09-22 17:25:36 PDT
Simon, please let me know if you think the new code will not do the same thing as the existing code.
Simon Fraser (smfr)
Comment 3 2011-09-22 17:29:23 PDT
Comment on attachment 108425 [details] Patch Looks right to me.
WebKit Review Bot
Comment 4 2011-09-22 21:09:30 PDT
Comment on attachment 108425 [details] Patch Clearing flags on attachment: 108425 Committed r95782: <http://trac.webkit.org/changeset/95782>
WebKit Review Bot
Comment 5 2011-09-22 21:09:34 PDT
All reviewed patches have been landed. Closing bug.
Julien Chaffraix
Comment 6 2011-09-23 13:01:24 PDT
Comment on attachment 108425 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108425&action=review > Source/WebCore/platform/graphics/ShadowBlur.cpp:359 > + m_blurRadius.scale(1 / transform.xScale(), 1 / transform.yScale()); This line is failing on the Intel Debug bot. Here is the message: ShadowBlur.cpp:359: warning: implicit conversion shortens 64-bit value into a 32-bit value ShadowBlur.cpp:359: warning: implicit conversion shortens 64-bit value into a 32-bit value xScale() and yScale() return a double that gets rounded to a float in FloatSize::scale(). Should I file a follow-up bug to fix the bot?
Simon Fraser (smfr)
Comment 7 2011-09-23 13:04:29 PDT
Yes please (or just post a patch here).
Note You need to log in before you can comment on or make changes to this bug.