Bug 68651

Summary: De-virtualize JSCell::getJSNumber
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67690    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Retrying windows
none
Retrying windows oliver: review+

Description Mark Hahnenberg 2011-09-22 13:11:02 PDT
In the ongoing process of de-virtualizing JSCell, we now come to JSCell::getJSNumber.
Comment 1 Mark Hahnenberg 2011-09-22 14:55:40 PDT
Created attachment 108405 [details]
Patch
Comment 2 Geoffrey Garen 2011-09-22 16:00:35 PDT
Comment on attachment 108405 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108405&action=review

Please make NumberObject-ness a type instead of a flag.

> Source/JavaScriptCore/runtime/JSTypeInfo.h:46
> +    static const unsigned IsNumberObject = 1 << 9;

I think this would be better as a JSType rather than a Structure flag. Flags are states that many kinds of objects might have; types identify a specific kind of object. Nothing other than NumberObject wants to set the IsNumberObject flag.
Comment 3 Mark Hahnenberg 2011-09-22 16:45:02 PDT
Created attachment 108418 [details]
Patch
Comment 4 Mark Hahnenberg 2011-09-22 16:46:53 PDT
Created attachment 108419 [details]
Patch
Comment 5 Mark Hahnenberg 2011-09-22 17:34:37 PDT
Created attachment 108430 [details]
Patch
Comment 6 Geoffrey Garen 2011-09-22 17:39:11 PDT
Comment on attachment 108430 [details]
Patch

r=me
Comment 7 Mark Hahnenberg 2011-09-23 13:05:40 PDT
Created attachment 108514 [details]
Retrying windows
Comment 8 Mark Hahnenberg 2011-09-23 13:11:27 PDT
Created attachment 108516 [details]
Retrying windows
Comment 9 Oliver Hunt 2011-09-23 18:05:36 PDT
Comment on attachment 108516 [details]
Retrying windows

r=me
Comment 10 Mark Hahnenberg 2011-09-23 18:19:02 PDT
Committed r95893: <http://trac.webkit.org/changeset/95893>