Bug 68651

Summary:

De-virtualize JSCell::getJSNumber

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenberg>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenberg>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

67690

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Retrying windows	none
Retrying windows	oliver: review+

Mark Hahnenberg

Reported 2011-09-22 13:11:02 PDT

In the ongoing process of de-virtualizing JSCell, we now come to JSCell::getJSNumber.

Attachments
Patch (8.04 KB, patch) 2011-09-22 14:55 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (8.96 KB, patch) 2011-09-22 16:45 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (8.98 KB, patch) 2011-09-22 16:46 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (9.23 KB, patch) 2011-09-22 17:34 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Retrying windows (9.37 KB, patch) 2011-09-23 13:05 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Retrying windows (9.28 KB, patch) 2011-09-23 13:11 PDT, Mark Hahnenberg	oliver: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Mark Hahnenberg

Comment 1 2011-09-22 14:55:40 PDT

Created attachment 108405 [details] Patch

Geoffrey Garen

Comment 2 2011-09-22 16:00:35 PDT

Comment on attachment 108405 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108405&action=review Please make NumberObject-ness a type instead of a flag. > Source/JavaScriptCore/runtime/JSTypeInfo.h:46 > + static const unsigned IsNumberObject = 1 << 9; I think this would be better as a JSType rather than a Structure flag. Flags are states that many kinds of objects might have; types identify a specific kind of object. Nothing other than NumberObject wants to set the IsNumberObject flag.

Mark Hahnenberg

Comment 3 2011-09-22 16:45:02 PDT

Created attachment 108418 [details] Patch

Mark Hahnenberg

Comment 4 2011-09-22 16:46:53 PDT

Created attachment 108419 [details] Patch

Mark Hahnenberg

Comment 5 2011-09-22 17:34:37 PDT

Created attachment 108430 [details] Patch

Geoffrey Garen

Comment 6 2011-09-22 17:39:11 PDT

Comment on attachment 108430 [details] Patch r=me