Bug 68621

Summary:

build-webkit goes totally haywire on Windows if there are spaces in the path to the WebKit source tree

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Tools / Tests

Assignee:

Adam Roben (:aroben) <aroben>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

sfalken

Priority:

Keywords:

PlatformOnly

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath	sullivan: review+

Adam Roben (:aroben)

Reported 2011-09-22 08:20:47 PDT

To reproduce: 1. Check out WebKit to some location that has spaces in its path 2. build-webkit You'll get all sorts of funky errors from Visual Studio.

Attachments
Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath (1.40 KB, patch) 2011-09-22 08:23 PDT, Adam Roben (:aroben)	sullivan: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2011-09-22 08:23:24 PDT

Created attachment 108337 [details] Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath

Adam Roben (:aroben)

Comment 2 2011-09-22 10:51:26 PDT

Committed r95731: <http://trac.webkit.org/changeset/95731>

Note You need to log in before you can comment on or make changes to this bug.