Bug 68613

Summary: Web Inspector: split DOM.attributesUpdated into attributeModified and attributeRemoved. Send attribute name and value within the event.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
[Patch] separated attrRemoved event on the front-end as well. yurys: review+

Pavel Feldman
Reported 2011-09-22 05:39:48 PDT
This change also splits attributeModified and attributeRemoved notifications.
Attachments
Patch (18.80 KB, patch)
2011-09-26 09:32 PDT, Pavel Feldman
no flags
[Patch] separated attrRemoved event on the front-end as well. (28.46 KB, patch)
2011-09-27 06:58 PDT, Pavel Feldman
yurys: review+
Pavel Feldman
Comment 1 2011-09-26 09:32:24 PDT
Yury Semikhatsky
Comment 2 2011-09-27 04:51:37 PDT
Comment on attachment 108677 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108677&action=review > Source/WebCore/inspector/Inspector.draft-01.json:1182 > + { "name": "name", "type": "string", "description": "Local attirbute name." }, typo: attirbute -> attribute, I'd also change it to Attribute's local name. > Source/WebCore/inspector/Inspector.draft-01.json:1183 > + { "name": "value", "type": "string", "description": "Attirbute name." } Attirbute name. -> New attribute value. > Source/WebCore/inspector/Inspector.json:1183 > + { "name": "value", "type": "string", "description": "Attirbute name." } Same typos here. > Source/WebCore/inspector/front-end/StylesSidebarPane.js:1681 > + this._parentPane._userOperation = true; This lines don't seem to be a part of this change, remove them.
Pavel Feldman
Comment 3 2011-09-27 06:58:14 PDT
Created attachment 108842 [details] [Patch] separated attrRemoved event on the front-end as well.
Yury Semikhatsky
Comment 4 2011-09-27 07:07:33 PDT
Comment on attachment 108842 [details] [Patch] separated attrRemoved event on the front-end as well. View in context: https://bugs.webkit.org/attachment.cgi?id=108842&action=review > LayoutTests/inspector/elements/mutate-unknown-node.html-disabled:31 > + node = event.data.node || event.data; Please use two separate listeners instead. > Source/WebCore/inspector/front-end/StylesSidebarPane.js:287 > + // Chanding style attribute will anyways generate _styleInvalidated message. Changing > Source/WebCore/inspector/front-end/StylesSidebarPane.js:291 > + // "classname" attribute might have changed. Update styles unless they are being edited. classname -> class
Pavel Feldman
Comment 5 2011-09-27 07:12:16 PDT
Note You need to log in before you can comment on or make changes to this bug.