| Summary: | Web Inspector: split DOM.attributesUpdated into attributeModified and attributeRemoved. Send attribute name and value within the event. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Pavel Feldman
2011-09-22 05:39:48 PDT
Created attachment 108677 [details]
Patch
Comment on attachment 108677 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108677&action=review > Source/WebCore/inspector/Inspector.draft-01.json:1182 > + { "name": "name", "type": "string", "description": "Local attirbute name." }, typo: attirbute -> attribute, I'd also change it to Attribute's local name. > Source/WebCore/inspector/Inspector.draft-01.json:1183 > + { "name": "value", "type": "string", "description": "Attirbute name." } Attirbute name. -> New attribute value. > Source/WebCore/inspector/Inspector.json:1183 > + { "name": "value", "type": "string", "description": "Attirbute name." } Same typos here. > Source/WebCore/inspector/front-end/StylesSidebarPane.js:1681 > + this._parentPane._userOperation = true; This lines don't seem to be a part of this change, remove them. Created attachment 108842 [details]
[Patch] separated attrRemoved event on the front-end as well.
Comment on attachment 108842 [details] [Patch] separated attrRemoved event on the front-end as well. View in context: https://bugs.webkit.org/attachment.cgi?id=108842&action=review > LayoutTests/inspector/elements/mutate-unknown-node.html-disabled:31 > + node = event.data.node || event.data; Please use two separate listeners instead. > Source/WebCore/inspector/front-end/StylesSidebarPane.js:287 > + // Chanding style attribute will anyways generate _styleInvalidated message. Changing > Source/WebCore/inspector/front-end/StylesSidebarPane.js:291 > + // "classname" attribute might have changed. Update styles unless they are being edited. classname -> class Committed r96106: <http://trac.webkit.org/changeset/96106> |