Bug 6860

Summary:

REGRESSION: crash when setting a list with list-style: none to display: none

Product:

WebKit

Reporter:

Maciej Stachowiak <mjs>

Component:

Layout and Rendering

Assignee:

Maciej Stachowiak <mjs>

Status:

RESOLVED WORKSFORME

Severity:

Major

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
A test case demonstrating the crash	none
the fix (including test case)	timo: review+

Maciej Stachowiak

Reported 2006-01-26 19:29:08 PST

When you change a list that has list-style: none to also be display: none, there is a crash due to a missing nil check.

Attachments
A test case demonstrating the crash (451 bytes, text/html) 2006-01-26 19:31 PST, Maciej Stachowiak	no flags	Details
the fix (including test case) (4.22 KB, patch) 2006-01-26 19:40 PST, Maciej Stachowiak	timo: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Maciej Stachowiak

Comment 1 2006-01-26 19:31:31 PST

Created attachment 6004 [details] A test case demonstrating the crash

Maciej Stachowiak

Comment 2 2006-01-26 19:31:54 PST

This is a regression, it does not happen in Safari 2.0.2.

Maciej Stachowiak

Comment 3 2006-01-26 19:40:48 PST

Created attachment 6005 [details] the fix (including test case)

Maciej Stachowiak

Comment 4 2006-01-26 19:45:02 PST

A reproducible crasher regression should be P1.

Tim Omernick

Comment 5 2006-01-26 20:44:10 PST

Comment on attachment 6005 [details] the fix (including test case) r=me

Maciej Stachowiak

Comment 6 2006-01-26 21:15:56 PST

Looks like Dave Harrison fixed this (in the exact same way, line for line) but I'll add the layout test anyway.

Eric Seidel (no email)

Comment 7 2006-01-31 21:20:48 PST

Removing Regression keyword from bugs already fixed.

Note You need to log in before you can comment on or make changes to this bug.