Bug 68594

Summary:

[EFL] Remove useless assignment code in _ewk_tiled_backing_store_zoom_set_internal.

Product:

WebKit

Reporter:

KwangHyuk <hyuki.kim>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, gyuyoung.kim, leandro, lucas.de.marchi, rakuco, ryuan.choi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Linux

Attachments:

Description	Flags
Patch.	none

KwangHyuk

Reported 2011-09-21 23:26:57 PDT

As the 1st assignment of local variable bx in _ewk_tiled_backing_store_zoom_set_internal isn't effective at all, this patch just removes it.

Attachments
Patch. (2.07 KB, patch) 2011-09-21 23:28 PDT, KwangHyuk	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

KwangHyuk

Comment 1 2011-09-21 23:28:58 PDT

Created attachment 108280 [details] Patch.

Lucas De Marchi

Comment 2 2011-09-22 06:09:53 PDT

Comment on attachment 108280 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=108280&action=review > Source/WebKit/efl/ChangeLog:7 > + [EFL] Remove useless assignment code in _ewk_tiled_backing_store_zoom_set_internal. > + https://bugs.webkit.org/show_bug.cgi?id=68594 > + > + As the 1st assignment of local variable bx in _ewk_tiled_backing_store_zoom_set_internal > + isn't effective at all, this patch just removes it. Are you using any static analyzer tool? Could you mention it here? I think patches like this would be better to be applied all together instead of going through each function and opening a separate bug.

KwangHyuk

Comment 3 2011-09-22 06:19:34 PDT

> Are you using any static analyzer tool? Could you mention it here? > > I think patches like this would be better to be applied all together instead of going through each function and opening a separate bug. No, Unfortunately, static analyzer didn't detect it ever before. I noticed this while I was checking the way to reduce number of calling smart calculate on ewk's tiled backing store.

Raphael Kubo da Costa (:rakuco)

Comment 4 2011-09-22 09:47:36 PDT

LGTM.

Gyuyoung Kim

Comment 5 2011-09-27 19:13:14 PDT

Comment on attachment 108280 [details] Patch. LGTM. 1503 line is unneeded code.

WebKit Review Bot

Comment 6 2011-09-28 19:51:17 PDT

Comment on attachment 108280 [details] Patch. Clearing flags on attachment: 108280 Committed r96291: <http://trac.webkit.org/changeset/96291>

WebKit Review Bot

Comment 7 2011-09-28 19:51:22 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.