Bug 68587 – Enable WEB_AUDIO by default in the WebKit/mac port.

• Component: New Bugs
• Status: RESOLVED FIXED

[Jer Noble]

Enable WEB_AUDIO by default in the WebKit/mac port.

[Jer Noble]

Created attachment 108365 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 108365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108365&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:7006
> +				CD0DBFF01422768500280263 /* IRC_Composite_C_R0195_T345_P345.wav in Copy Audio Resources */,

What does this to do the framework size?

[Jer Noble]

(In reply to comment #2)
> (From update of attachment 108365 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108365&action=review
> 
> > Source/WebCore/WebCore.xcodeproj/project.pbxproj:7006
> > +				CD0DBFF01422768500280263 /* IRC_Composite_C_R0195_T345_P345.wav in Copy Audio Resources */,
> 
> What does this to do the framework size?

It adds about 980 KB of resources.

[Chris Rogers]

The total data size of the files is around 250K - the folder may show a larger size due to the number of files and disk sector allocation

[WebKit Review Bot]

Comment on attachment 108365 [details]
Patch

Clearing flags on attachment: 108365

Committed r96526: <http://trac.webkit.org/changeset/96526>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Jer Noble]

Reverted r96526 for reason:

WEB_AUDIO has numerous 64->32 bit casting warnings, causing build breakages where -Wall is enabled.

Committed r96545: <http://trac.webkit.org/changeset/96545>

[Jer Noble]

Created attachment 109868 [details]
Patch

Now that bug #69292 is fixed, resubmitting this patch for approval, but now with LayoutTest changes to support the additional Window properties added by this patch.

[WebKit Review Bot]

Comment on attachment 109868 [details]
Patch

Clearing flags on attachment: 109868

Committed r96774: <http://trac.webkit.org/changeset/96774>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Ryosuke Niwa]

It seems like fast/dom/Window/window-properties.html, fast/dom/prototype-inheritance-2.html, and fast/js/global-constructors.html started failing after this patch was landed:
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r96941%20(33722)/results.html

[Jer Noble]

(In reply to comment #11)
> It seems like fast/dom/Window/window-properties.html, fast/dom/prototype-inheritance-2.html, and fast/js/global-constructors.html started failing after this patch was landed:
> http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r96941%20(33722)/results.html

Filed https://bugs.webkit.org/show_bug.cgi?id=69800.

[Grant Galitz]

Web audio still has issues with its onprocessaudio event for the JavaScriptNode firing late / not enough on Mac OS X (Gaps in the audio happen sometimes, and fails miserably with timing during high CPU taxing, unlike how flash performs). However, the web audio for windows (tested in chrome on windows 7) is completely trashed, and fails to fire its events enough under light CPU load.

Reference URL: http://grantgalitz.org/gamecenter/#PokemonYellow (Sigh, I know this is getting old, but my JavaScript GameBoy Color does use Web Audio + Flash Audio + Mozilla Audio). To force web audio on windows / linux, disable flash, since I blacklist web audio upon detection of these host OSes due to the critical web audio bugs (So I attempt flash over web audio for win/linux.).