Bug 68586

Summary: Add X86 GPRInfo for DFG JIT.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67460    
Attachments:
Description Flags
Fix ggaren: review+

Description Gavin Barraclough 2011-09-21 16:34:15 PDT
X86 has fewer registers!
Comment 1 Gavin Barraclough 2011-09-21 16:35:09 PDT
Created attachment 108252 [details]
Fix
Comment 2 Geoffrey Garen 2011-09-21 16:44:37 PDT
Comment on attachment 108252 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=108252&action=review

r=me

> Source/JavaScriptCore/dfg/DFGGPRInfo.h:46
> +    // These registers match the old JIT.

Let's call this "baseline JIT".

> Source/JavaScriptCore/dfg/DFGGPRInfo.h:59
> +    static const GPRReg argumentGPR0 = X86Registers::ecx; // regT2
> +    static const GPRReg argumentGPR1 = X86Registers::edx; // regT1
> +    static const GPRReg returnValueGPR = X86Registers::eax; // regT0
> +    static const GPRReg returnValueGPR2 = X86Registers::edx; // regT1

This numbering convention is not consistent. Would be good to make it so in a future patch.
Comment 3 Gavin Barraclough 2011-09-21 16:49:30 PDT
fixed in r95684