Bug 68557

Summary: Replace jsFunctionVPtr compares with a type check on the Structure.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 68603, 68606    
Bug Blocks:    
Attachments:
Description Flags
Fix oliver: review+

Gavin Barraclough
Reported 2011-09-21 12:16:26 PDT
This will permit calls to still optimize to subclasses of JSFunction that have the correct type (but a different C++ vptr).
Attachments
Fix (20.93 KB, patch)
2011-09-21 12:18 PDT, Gavin Barraclough 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2011-09-21 12:18:57 PDT
Created attachment 108205 [details] Fix No perf impact.
WebKit Review Bot
Comment 2 2011-09-21 12:22:02 PDT
Attachment 108205 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/runtime/JSObject.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 3 2011-09-21 12:58:45 PDT
Fixed in r95666
Note You need to log in before you can comment on or make changes to this bug.