Bug 68548

Summary:

[WK2] Implement TextChecker for WebKit2 GTK+

Product:

WebKit

Reporter:

Ravi Phaneendra Kasibhatla <ravi.kasibhatla>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

amruthraj, andersca, aroben, gustavo, jberlin, kbalazs, mrobinson, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

68532

Bug Blocks:

68547

Attachments:

Description	Flags
WebKit2 GTK port changes for TextChecker	gustavo: commit-queue-
Patch for text checker implementation for WebKit2 GTK port.	none
Patch for text checker implementation for WebKit2 GTK port	none

Ravi Phaneendra Kasibhatla

Reported 2011-09-21 11:16:00 PDT

Created attachment 108186 [details] WebKit2 GTK port changes for TextChecker The bug captures the WebKit2 GTK port changes for implementation of the TextChecker. This bug captures part of the changes https://bugs.webkit.org/show_bug.cgi?id=68532.

Attachments
WebKit2 GTK port changes for TextChecker (10.89 KB, patch) 2011-09-21 11:16 PDT, Ravi Phaneendra Kasibhatla	gustavo: commit-queue-	Details Formatted Diff Diff
Patch for text checker implementation for WebKit2 GTK port. (11.24 KB, patch) 2011-10-07 04:43 PDT, Ravi Phaneendra Kasibhatla	no flags	Details Formatted Diff Diff
Patch for text checker implementation for WebKit2 GTK port (13.54 KB, patch) 2011-10-11 22:50 PDT, Ravi Phaneendra Kasibhatla	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Gustavo Noronha (kov)

Comment 1 2011-09-21 11:21:05 PDT

Comment on attachment 108186 [details] WebKit2 GTK port changes for TextChecker Attachment 108186 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9767820

Ravi Phaneendra Kasibhatla

Comment 2 2011-10-07 04:43:03 PDT

Created attachment 110124 [details] Patch for text checker implementation for WebKit2 GTK port. Implements the TextChecker for WebKit2 GTK port. With this patch, the port specific implementation is completed and to enable text checker the callback interfaces needs to be implemented at client level. The client interfaces implementation will be addressed as part of https://bugs.webkit.org/show_bug.cgi?id=68547

Martin Robinson

Comment 3 2011-10-07 08:42:18 PDT

Removing the GTK tag because this change modifies the code from other ports.

Ravi Phaneendra Kasibhatla

Comment 4 2011-10-07 10:58:08 PDT

Since the mac-ews can't be triggered by me, built the patch on trunk head on mac port and found no issues (compilation or runtime).

Ravi Phaneendra Kasibhatla

Comment 5 2011-10-11 22:50:34 PDT

Created attachment 110639 [details] Patch for text checker implementation for WebKit2 GTK port Missed changelog in earlier patch. Attaching with ChangeLog changes also.

WebKit Review Bot

Comment 6 2011-10-13 12:35:40 PDT

Comment on attachment 110639 [details] Patch for text checker implementation for WebKit2 GTK port Clearing flags on attachment: 110639 Committed r97385: <http://trac.webkit.org/changeset/97385>

WebKit Review Bot

Comment 7 2011-10-13 12:35:45 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.