Bug 68543

Summary: [CSSRegions] Make sure when regions change that we treat it like page dimensions changing.
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: donggwan.kim, mibalan, mihnea, WebkitBugTracker, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+

Description Dave Hyatt 2011-09-21 10:39:56 PDT
Make sure when regions change that we treat it like page dimensions changing, so that we recheck pagination boundaries for slicing.
Comment 1 Dave Hyatt 2011-09-21 10:44:21 PDT
Created attachment 108178 [details]
Patch
Comment 2 WebKit Review Bot 2011-09-21 10:46:23 PDT
Attachment 108178 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2011-09-21 10:49:56 PDT
Created attachment 108179 [details]
Patch
Comment 4 Simon Fraser (smfr) 2011-09-21 10:56:13 PDT
Comment on attachment 108179 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108179&action=review

> Source/WebCore/ChangeLog:5
> +        Make sure that when regions change dimensions that we recompute pagination slices.

Extra 'that'
Comment 5 Mihnea Ovidenie 2012-12-28 00:08:06 PST
Landed in http://trac.webkit.org/changeset/95648