Bug 68543 - [CSSRegions] Make sure when regions change that we treat it like page dimensions changing.
Summary: [CSSRegions] Make sure when regions change that we treat it like page dimensi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 57312
  Show dependency treegraph
 
Reported: 2011-09-21 10:39 PDT by Dave Hyatt
Modified: 2012-12-28 00:08 PST (History)
5 users (show)

See Also:


Attachments
Patch (13.85 KB, patch)
2011-09-21 10:44 PDT, Dave Hyatt
no flags Details | Formatted Diff | Diff
Patch (13.92 KB, patch)
2011-09-21 10:49 PDT, Dave Hyatt
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2011-09-21 10:39:56 PDT
Make sure when regions change that we treat it like page dimensions changing, so that we recheck pagination boundaries for slicing.
Comment 1 Dave Hyatt 2011-09-21 10:44:21 PDT
Created attachment 108178 [details]
Patch
Comment 2 WebKit Review Bot 2011-09-21 10:46:23 PDT
Attachment 108178 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2011-09-21 10:49:56 PDT
Created attachment 108179 [details]
Patch
Comment 4 Simon Fraser (smfr) 2011-09-21 10:56:13 PDT
Comment on attachment 108179 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108179&action=review

> Source/WebCore/ChangeLog:5
> +        Make sure that when regions change dimensions that we recompute pagination slices.

Extra 'that'
Comment 5 Mihnea Ovidenie 2012-12-28 00:08:06 PST
Landed in http://trac.webkit.org/changeset/95648