Bug 68537

Summary: Web Inspector: add minimal error handling to the DOM breakpoints.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Pavel Feldman
Reported 2011-09-21 08:25:50 PDT
Patch to follow.
Attachments
Patch (4.19 KB, patch)
2011-09-21 08:27 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-09-21 08:27:32 PDT
Created attachment 108166 [details] Patch
Yury Semikhatsky
Comment 2 2011-09-21 08:31:55 PDT
Comment on attachment 108166 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108166&action=review > Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp:189 > + *errorString = "Unknown DOM breakpoint type: " + typeString; Use makeString instead?
Pavel Feldman
Comment 3 2011-09-21 08:39:03 PDT
Committed r95634: <http://trac.webkit.org/changeset/95634>
Note You need to log in before you can comment on or make changes to this bug.