Bug 68522

Summary: WebSocket: Split Hixie76 length-prefixed frames aren't handled correctly
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebCore Misc.Assignee: Yuta Kitamura <yutak>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, danw, mrobinson, tkent, webkit.review.bot, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Philippe Normand
Reported 2011-09-21 05:26:52 PDT
Diff: --- /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/http/tests/websocket/tests/hixie76/error-detect-expected.txt +++ /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/http/tests/websocket/tests/hixie76/error-detect-actual.txt @@ -3,9 +3,8 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". WebSocket is open -received:done WebSocket is closed -PASS errorCount is 255 +FAIL errorCount should be 255. Was 241. PASS successfullyParsed is true TEST COMPLETE
Attachments
Patch (6.52 KB, patch)
2011-11-28 06:20 PST, Yuta Kitamura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yuta Kitamura
Comment 1 2011-11-28 05:21:21 PST
I was digging this issue these days, and this turned out to be a real bug in WebSocketChannel. This happens only when the following conditions are met: - Hixie76 binary (length-prefixed) frame is sent from the server. - The client receives only the first byte of the frame, and the remaining bytes later (i.e. split into two different WebSocketChannel::didReceiveData() calls). GTK tests have reproduced this situation (somewhat) reliably. I will upload a patch that fixes this problem shortly.
Yuta Kitamura
Comment 2 2011-11-28 05:24:46 PST
Updating bug summary to reflect the actual problem
Yuta Kitamura
Comment 3 2011-11-28 06:20:00 PST
Created attachment 116746 [details] Patch
Martin Robinson
Comment 4 2011-11-28 06:42:06 PST
(In reply to comment #3) > Created an attachment (id=116746) [details] > Patch Would you mind also removing http/tests/websocket/tests/hixie76/error-detect.html from the GTK+ test_expectation.txt file?
Kent Tamura
Comment 5 2011-11-28 19:05:44 PST
Comment on attachment 116746 [details] Patch Looks ok.
Yuta Kitamura
Comment 6 2011-11-28 21:24:12 PST
Thanks.
WebKit Review Bot
Comment 7 2011-11-28 22:21:53 PST
Comment on attachment 116746 [details] Patch Clearing flags on attachment: 116746 Committed r101326: <http://trac.webkit.org/changeset/101326>
WebKit Review Bot
Comment 8 2011-11-28 22:21:58 PST
All reviewed patches have been landed. Closing bug.
Philippe Normand
Comment 9 2011-11-29 00:53:26 PST
(In reply to comment #4) > (In reply to comment #3) > > Created an attachment (id=116746) [details] [details] > > Patch > > Would you mind also removing http/tests/websocket/tests/hixie76/error-detect.html from the GTK+ test_expectation.txt file? I unskipped it in r101338.
Yuta Kitamura
Comment 10 2011-11-29 00:58:05 PST
Thanks!
Note You need to log in before you can comment on or make changes to this bug.