Bug 68492

Summary: Clean up CSS Counter code
Product: WebKit Reporter: Adam Klein <adamk>
Component: New BugsAssignee: Adam Klein <adamk>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix nitpick
none
Patch for landing none

Adam Klein
Reported 2011-09-20 17:44:45 PDT
Clean up CSS Counter code
Attachments
Patch (13.28 KB, patch)
2011-09-20 17:51 PDT, Adam Klein 		no flags
DetailsFormatted DiffDiff
Fix nitpick (13.38 KB, patch)
2011-09-21 11:22 PDT, Adam Klein 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.38 KB, patch)
2011-09-21 11:24 PDT, Adam Klein 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Klein
Comment 1 2011-09-20 17:51:11 PDT
Created attachment 108088 [details] Patch
Adam Klein
Comment 2 2011-09-21 09:22:29 PDT
Adding a couple reviewers who reviewed my previous change in this area (http://trac.webkit.org/changeset/95071).
Tony Chang
Comment 3 2011-09-21 10:22:46 PDT
Comment on attachment 108088 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108088&action=review > Source/WebCore/css/CSSParser.cpp:3675 > short ls = 0; Nit: While we're here, this should probably be an int since CSSParserValue::id is an int and we should use a better variable name than ls (like cssValueID or listStyleID).
Adam Klein
Comment 4 2011-09-21 11:22:52 PDT
Created attachment 108188 [details] Fix nitpick
Adam Klein
Comment 5 2011-09-21 11:24:16 PDT
Created attachment 108192 [details] Patch for landing
WebKit Review Bot
Comment 6 2011-09-21 12:46:55 PDT
Comment on attachment 108192 [details] Patch for landing Clearing flags on attachment: 108192 Committed r95664: <http://trac.webkit.org/changeset/95664>
WebKit Review Bot
Comment 7 2011-09-21 12:46:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.