Bug 68488

Summary:

garden-o-matic results view should sort test and builder names

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

64188

Attachments:

Description	Flags
Patch	aestes: review+, aestes: commit-queue-

Description Adam Barth 2011-09-20 16:14:07 PDT

garden-o-matic results view should sort test and builder names

Comment 1 Adam Barth 2011-09-20 16:15:45 PDT

Created attachment 108073 [details]
Patch

Comment 2 Andy Estes 2011-09-22 22:25:53 PDT

Comment on attachment 108073 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108073&action=review

r=me

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:172
> +        Object.keys(resultsByTest).sort().forEach(function (testName) {

Super nit: you probably don't want that space before the anonymous function's parameter list.

Comment 3 Adam Barth 2011-09-22 23:24:28 PDT

Comment on attachment 108073 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108073&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:172
>> +        Object.keys(resultsByTest).sort().forEach(function (testName) {
> 
> Super nit: you probably don't want that space before the anonymous function's parameter list.

Thanks.

Comment 4 Adam Barth 2011-09-27 10:52:30 PDT

Committed r96129: <http://trac.webkit.org/changeset/96129>