Bug 68488 - garden-o-matic results view should sort test and builder names
Summary: garden-o-matic results view should sort test and builder names
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 64188
  Show dependency treegraph
 
Reported: 2011-09-20 16:14 PDT by Adam Barth
Modified: 2011-09-27 10:52 PDT (History)
0 users

See Also:


Attachments
Patch (2.25 KB, patch)
2011-09-20 16:15 PDT, Adam Barth
aestes: review+
aestes: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-09-20 16:14:07 PDT
garden-o-matic results view should sort test and builder names
Comment 1 Adam Barth 2011-09-20 16:15:45 PDT
Created attachment 108073 [details]
Patch
Comment 2 Andy Estes 2011-09-22 22:25:53 PDT
Comment on attachment 108073 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108073&action=review

r=me

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:172
> +        Object.keys(resultsByTest).sort().forEach(function (testName) {

Super nit: you probably don't want that space before the anonymous function's parameter list.
Comment 3 Adam Barth 2011-09-22 23:24:28 PDT
Comment on attachment 108073 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108073&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:172
>> +        Object.keys(resultsByTest).sort().forEach(function (testName) {
> 
> Super nit: you probably don't want that space before the anonymous function's parameter list.

Thanks.
Comment 4 Adam Barth 2011-09-27 10:52:30 PDT
Committed r96129: <http://trac.webkit.org/changeset/96129>