Summary: | Add webkit 'filter' value to RenderStyle | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||||
Component: | CSS | Assignee: | Dean Jackson <dino> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cmarrin, krit, peter, simon.fraser, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 68469, 68472 | ||||||||
Attachments: |
|
Description
Dean Jackson
2011-09-20 14:05:43 PDT
This is wrong. Obviously the property should be prefixed, so I'm retitling this to be implement a new RenderStyle value. I propose the implementation goes: 1. prefixed version for HTML. SVG filter remains untouched. 2. implement prefixed version for SVG in addition to existing filter (who wins?) 3. eventually merge when we can drop prefix (In reply to comment #2) > This is wrong. Obviously the property should be prefixed, so I'm retitling this to be implement a new RenderStyle value. I propose the implementation goes: > > 1. prefixed version for HTML. SVG filter remains untouched. > 2. implement prefixed version for SVG in addition to existing filter (who wins?) But you still plan to use the same work flow and the same CSS property for both, HTML and SVG, no? (In reply to comment #3) > (In reply to comment #2) > > This is wrong. Obviously the property should be prefixed, so I'm retitling this to be implement a new RenderStyle value. I propose the implementation goes: > > > > 1. prefixed version for HTML. SVG filter remains untouched. > > 2. implement prefixed version for SVG in addition to existing filter (who wins?) > > But you still plan to use the same work flow and the same CSS property for both, HTML and SVG, no? Yes, eventually. (And eventually is not that long away - I just don't want to disrupt the working SVG filter path while CSS is in flux) Created attachment 108738 [details]
Patch
Comment on attachment 108738 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108738&action=review > Source/WebCore/platform/graphics/filters/FilterOperation.h:230 > + double m_offsetX; > + double m_offsetY; What is this offset? Is it a blur radius? If so, how is it defined? (In reply to comment #6) > (From update of attachment 108738 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=108738&action=review > > > Source/WebCore/platform/graphics/filters/FilterOperation.h:230 > > + double m_offsetX; > > + double m_offsetY; > > What is this offset? Is it a blur radius? If so, how is it defined? Yes, a blur radius. We expose lengths into the filter operation. I expect we'll need to plumb them through similar to the way TranslateTransformOperation has to. Created attachment 108764 [details]
Patch
New patch with Simon's change to stdDeviation. I guess I shouldn't copy the r+ (not even sure I can do that) |