Bug 68409 – Refactor Heap allocation logic into separate AllocationSpace class

• Component: New Bugs
• Status: RESOLVED FIXED

[Oliver Hunt]

Refactor Heap allocation logic into separate AllocationSpace class

[Oliver Hunt]

Created attachment 107937 [details]
Patch

[Oliver Hunt]

Committed r95493: <http://trac.webkit.org/changeset/95493>

[Ryosuke Niwa]

It seems like this patch broke JSC on Windows:

2>   Creating library C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\lib\JavaScriptCore.lib and object C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\lib\JavaScriptCore.exp
2>JavaScriptCore.exp : error LNK2001: unresolved external symbol "public: void * __thiscall JSC::Heap::allocate(struct JSC::MarkedSpace::SizeClass &)" (?allocate@Heap@JSC@@QAEPAXAAUSizeClass@MarkedSpace@2@@Z)
2>JavaScriptCore.exp : error LNK2001: unresolved external symbol "private: void * __thiscall JSC::Heap::allocateSlowCase(struct JSC::MarkedSpace::SizeClass &)" (?allocateSlowCase@Heap@JSC@@AAEPAXAAUSizeClass@MarkedSpace@2@@Z)
2>C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin\JavaScriptCore.dll : fatal error LNK1120: 2 unresolved externals
2>Build log was saved at "file://C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\obj\JavaScriptCore\BuildLog.htm"

[Ryosuke Niwa]

Thanks for http://trac.webkit.org/changeset/95496.

But it's still failing to build for whatever reason :(

http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/21105/steps/compile-webkit/logs/stdio

2>JavaScriptCore.exp : error LNK2001: unresolved external symbol "public: void * __thiscall JSC::AllocationSpace::allocate(struct JSC::MarkedSpace::SizeClass &)" (?allocate@AllocationSpace@JSC@@QAEPAXAAUSizeCla

It seems like cl.exe is getting confused by two overloaded allocate functions.  I tried moving function definitions into the class definition but didn't help.

Per IRC discussion with gbarra, I'm rolling out the patch for now.

[Oliver Hunt]

Created attachment 108019 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 108019 [details]
Patch

It seems like you'd have to modify JavaScriptCore.def as in http://trac.webkit.org/changeset/95496/trunk/Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def ?

[Oliver Hunt]

(In reply to comment #6)
> (From update of attachment 108019 [details])
> It seems like you'd have to modify JavaScriptCore.def as in http://trac.webkit.org/changeset/95496/trunk/Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def ?

I'm waiting for the win ews to turn, then i'll remove the bogus export, then wait for it to turn again, and add the correct one.

[Oliver Hunt]

Created attachment 108021 [details]
Patch

Remove the known bad exports

[Oliver Hunt]

Created attachment 108031 [details]
Patch

Add missing export

[Oliver Hunt]

Committed r95559: <http://trac.webkit.org/changeset/95559>