Bug 68402

Summary: WebViews are always inactive when used in NSPopover
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: WebKit APIAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Major CC: darin, sullivan
Priority: P1 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.7   
Attachments:
Description Flags
Proposed Change sullivan: review+, timothy: commit-queue-

Timothy Hatcher
Reported 2011-09-19 15:32:28 PDT
A WebView that is used in an NSPopover gets no hover or mouse move events, nor do CSS hovers work. The blinking insertion point also does not draw and text selection is always the inactive color. <rdar://problem/9754099>
Attachments
Proposed Change (8.33 KB, patch)
2011-09-19 15:41 PDT, Timothy Hatcher 		sullivan: review+
timothy: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2011-09-19 15:41:11 PDT
Created attachment 107931 [details] Proposed Change
John Sullivan
Comment 2 2011-09-19 15:48:26 PDT
Comment on attachment 107931 [details] Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=107931&action=review > Source/WebKit/mac/WebView/WebHTMLView.mm:3383 > + // unless the parent window looses key. So we need to remove the mouse moved observer. Typo, “looses” should be “loses”.
Darin Adler
Comment 3 2011-09-19 15:52:52 PDT
Comment on attachment 107931 [details] Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=107931&action=review > Source/WebKit/mac/ChangeLog:3 > + Make WebViews in NSPopovers render as they would in active windows. What about WKView? Do we have the same problem with WebKit2?
Timothy Hatcher
Comment 4 2011-09-20 06:35:56 PDT
(In reply to comment #3) > (From update of attachment 107931 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=107931&action=review > > > Source/WebKit/mac/ChangeLog:3 > > + Make WebViews in NSPopovers render as they would in active windows. > > What about WKView? Do we have the same problem with WebKit2? Filed as bug 68435 since I don't have a testcase for WKView yet, I'll fix it in a seperate patch.
Timothy Hatcher
Comment 5 2011-09-20 06:37:22 PDT
Fixed in r95534. http://trac.webkit.org/changeset/95534
Note You need to log in before you can comment on or make changes to this bug.